bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Manager: Query peer heights lazily while catching up #3208

Closed omerfirmak closed 2 years ago

omerfirmak commented 2 years ago
If we have unresponsive peers, the initial act of querying
each peer for their ledger heights could take a lot of time.

could help https://github.com/bosagora/agora/issues/3206

codecov[bot] commented 2 years ago

Codecov Report

Merging #3208 (1f07628) into v0.x.x (0c35bfe) will decrease coverage by 8.31%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           v0.x.x    #3208      +/-   ##
==========================================
- Coverage   87.48%   79.16%   -8.32%     
==========================================
  Files         166      212      +46     
  Lines       16927    19110    +2183     
==========================================
+ Hits        14808    15128     +320     
- Misses       2119     3982    +1863     
Flag Coverage Δ
integration 14.35% <ø> (?)
unittests 87.37% <100.00%> (-0.11%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/network/Manager.d 78.40% <100.00%> (-1.86%) :arrow_down:
source/agora/network/Client.d 82.44% <0.00%> (-4.59%) :arrow_down:
source/agora/utils/Utility.d 92.85% <0.00%> (-3.58%) :arrow_down:
source/agora/node/FullNode.d 73.33% <0.00%> (-1.52%) :arrow_down:
source/agora/test/Flash.d 95.12% <0.00%> (-0.11%) :arrow_down:
source/agora/consensus/protocol/Nominator.d 91.51% <0.00%> (ø)
agora/submodules/ocean/src/ocean/text/Ascii.d 0.00% <0.00%> (ø)
...a/submodules/ocean/src/ocean/core/array/Mutation.d 0.00% <0.00%> (ø)
...gora/submodules/ocean/src/ocean/text/convert/Utf.d 0.40% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c35bfe...1f07628. Read the comment docs.

omerfirmak commented 2 years ago

me ❤️ macOS