search

bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

NetMan: Optimize signature catchup #3210

Closed Geod24 closed 2 years ago

Geod24 commented 2 years ago

Found a bug in signature catchup: Namely, we do not verify the header we receive is valid. This can easily crash the node, which is how I noticed it. While looking deeper, I also noticed that this function is quite expensive, so here's an attempt at optimizing it. See each commit for a description. Still need some testing.

hewison-chris commented 2 years ago

Closing as new PR coming soon to address this.