bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Sign fetched block #3212

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

If a block is fetched from another node it is better to make sure our signature is in the block.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3212 (b26003b) into v0.x.x (1ceafbf) will increase coverage by 30.94%. The diff coverage is 91.07%.

@@             Coverage Diff             @@
##           v0.x.x    #3212       +/-   ##
===========================================
+ Coverage   20.14%   51.09%   +30.94%     
===========================================
  Files          64      371      +307     
  Lines        2879    37758    +34879     
===========================================
+ Hits          580    19291    +18711     
- Misses       2299    18467    +16168     
Flag Coverage Δ
integration 22.65% <19.04%> (+2.50%) :arrow_up:
unittests 87.35% <91.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/test/Base.d 80.31% <ø> (ø)
source/agora/test/InvalidBlockSigByzantine.d 96.29% <ø> (ø)
source/agora/node/Validator.d 90.45% <85.71%> (ø)
source/agora/consensus/protocol/Nominator.d 91.25% <87.50%> (ø)
source/agora/node/FullNode.d 76.66% <87.50%> (ø)
source/agora/network/Manager.d 79.20% <100.00%> (ø)
source/agora/test/BlockRewards.d 95.23% <100.00%> (ø)
source/agora/test/PeriodicCatchup.d 96.55% <100.00%> (ø)
...dules/ocean/src/ocean/text/convert/Integer_tango.d 49.39% <0.00%> (-10.85%) :arrow_down:
...ubmodules/ocean/src/ocean/text/convert/Formatter.d 55.27% <0.00%> (-1.01%) :arrow_down:
... and 320 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ceafbf...b26003b. Read the comment docs.

hewison-chris commented 2 years ago

All green:-)