bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Ledger: Move functions that work on ConsensusData to ValidatingLedger #3214

Closed omerfirmak closed 2 years ago

omerfirmak commented 2 years ago

Since regular nodes dont deal with ConsensusData at all.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3214 (ba582ba) into v0.x.x (dd2491c) will increase coverage by 0.47%. The diff coverage is 88.52%.

@@            Coverage Diff             @@
##           v0.x.x    #3214      +/-   ##
==========================================
+ Coverage   79.27%   79.75%   +0.47%     
==========================================
  Files         212      210       -2     
  Lines       19108    18978     -130     
==========================================
- Hits        15148    15136      -12     
+ Misses       3960     3842     -118     
Flag Coverage Δ
integration 16.80% <ø> (-3.35%) :arrow_down:
unittests 87.39% <88.52%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/Ledger.d 97.49% <88.52%> (+<0.01%) :arrow_up:
source/agora/utils/Log.d 48.34% <0.00%> (-10.60%) :arrow_down:
source/agora/network/Client.d 80.15% <0.00%> (-6.88%) :arrow_down:
source/agora/flash/Node.d 80.67% <0.00%> (-0.43%) :arrow_down:
agora/submodules/ocean/src/ocean/core/BitArray.d
agora/submodules/ocean/src/ocean/core/Buffer.d
source/agora/consensus/protocol/Nominator.d 91.59% <0.00%> (+0.07%) :arrow_up:
source/agora/node/FullNode.d 72.72% <0.00%> (+0.30%) :arrow_up:
source/agora/network/Manager.d 78.73% <0.00%> (+0.33%) :arrow_up:
source/agora/node/Validator.d 91.23% <0.00%> (+0.56%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd2491c...ba582ba. Read the comment docs.