bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

System Integration tests: `GenesisTimestamp` replacement for MacOS too #3217

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

It was silently failing to update the timestamp when the test is run locally on a MacBook.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3217 (6e87673) into v0.x.x (3169ed2) will increase coverage by 51.49%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           v0.x.x    #3217       +/-   ##
===========================================
+ Coverage   27.84%   79.33%   +51.49%     
===========================================
  Files         304      212       -92     
  Lines       29023    19118     -9905     
===========================================
+ Hits         8082    15168     +7086     
+ Misses      20941     3950    -16991     
Flag Coverage Δ
integration 17.78% <ø> (-10.07%) :arrow_down:
unittests 87.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/common/VibeTask.d 0.00% <0.00%> (-86.67%) :arrow_down:
source/agora/common/FileBasedLock.d 0.00% <0.00%> (-72.73%) :arrow_down:
source/agora/network/RPC.d 1.51% <0.00%> (-59.85%) :arrow_down:
source/agora/network/VibeManager.d 1.42% <0.00%> (-44.29%) :arrow_down:
source/agora/node/Runner.d 0.00% <0.00%> (-43.07%) :arrow_down:
source/scpd/scp/SCPDriver.d 60.00% <0.00%> (-15.00%) :arrow_down:
source/agora/consensus/Quorum.d 97.09% <0.00%> (-0.28%) :arrow_down:
source/scpd/scp/SCP.d 100.00% <0.00%> (ø)
source/agora/crypto/Crc16.d 100.00% <0.00%> (ø)
source/agora/consensus/data/UTXO.d 100.00% <0.00%> (ø)
... and 305 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3169ed2...6e87673. Read the comment docs.