codecov[bot]
commented
2 years ago Codecov Report
Merging #3219 (f85839f) into v0.x.x (e2c9637) will decrease coverage by
26.75%. The diff coverage is87.40%.
@@ Coverage Diff @@
## v0.x.x #3219 +/- ##
===========================================
- Coverage 79.16% 52.41% -26.76%
===========================================
Files 212 371 +159
Lines 19116 37759 +18643
===========================================
+ Hits 15134 19790 +4656
- Misses 3982 17969 +13987 | Flag | Coverage Δ | |
|---|---|---|
| integration | 28.81% <73.55%> (+9.20%) |
:arrow_up: |
| unittests | 87.35% <87.31%> (-0.03%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| source/agora/node/Runner.d | 57.35% <ø> (+57.35%) |
:arrow_up: |
| source/agora/test/Base.d | 80.31% <ø> (-0.20%) |
:arrow_down: |
| source/agora/test/InvalidBlockSigByzantine.d | 96.29% <ø> (ø) |
|
| source/agora/network/Manager.d | 80.26% <75.00%> (+1.52%) |
:arrow_up: |
| source/agora/consensus/protocol/Nominator.d | 91.07% <83.33%> (-1.25%) |
:arrow_down: |
| source/agora/node/Validator.d | 91.45% <85.71%> (+0.73%) |
:arrow_up: |
| source/agora/node/FullNode.d | 76.66% <87.50%> (+4.24%) |
:arrow_up: |
| source/agora/consensus/Ledger.d | 97.49% <88.52%> (+<0.01%) |
:arrow_up: |
| source/agora/node/Registry.d | 79.95% <100.00%> (+1.13%) |
:arrow_up: |
| source/agora/node/main.d | 44.85% <100.00%> (ø) |
|
| ... and 186 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 07da0c4...f85839f. Read the comment docs.
Even it is a small time window a node can be requested to terminate while it is in node initialization (
runNode). Returning as a bulk prevents already started parts to be shutdown during node termination.