Closed Geod24 closed 2 years ago
Before:
-rwxr-xr-x 2 geod24 staff 79769112 Mar 23 15:30 agora
After:
-rwxr-xr-x 2 geod24 staff 79285712 Mar 23 15:28 agora
Not as much as I'd hoped but still 500 kb of binary size gone, and hopefully a few module ctors.
Integration will have to be forced (and Faucet fixed)
Merging #3220 (023d7ef) into v0.x.x (e2c9637) will increase coverage by
8.25%
. The diff coverage is82.00%
.
@@ Coverage Diff @@
## v0.x.x #3220 +/- ##
==========================================
+ Coverage 79.16% 87.42% +8.25%
==========================================
Files 212 166 -46
Lines 19116 16927 -2189
==========================================
- Hits 15134 14798 -336
+ Misses 3982 2129 -1853
Flag | Coverage Δ | |
---|---|---|
integration | ? |
|
unittests | 87.42% <82.00%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
source/agora/common/Ensure.d | 100.00% <ø> (ø) |
|
source/agora/network/RPC.d | 1.51% <ø> (ø) |
|
source/agora/node/Runner.d | 0.00% <ø> (ø) |
|
source/agora/stats/Collector.d | 100.00% <ø> (ø) |
|
source/agora/stats/StatFormatter.d | 100.00% <ø> (ø) |
|
source/agora/test/Base.d | 80.31% <ø> (-0.20%) |
:arrow_down: |
source/agora/test/Crypto.d | 100.00% <ø> (ø) |
|
source/agora/test/InvalidBlockSigByzantine.d | 96.29% <ø> (ø) |
|
source/agora/utils/Log.d | 47.65% <33.33%> (-0.70%) |
:arrow_down: |
source/agora/utils/SCPPrettyPrinter.d | 91.72% <33.33%> (ø) |
|
... and 68 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 07da0c4...023d7ef. Read the comment docs.
All CIs (but integration) are green so going ahead with this.
Should reduce our footprint a bit.