bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

SCP fatal error triggered during `combineCandidates` #3224

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

Seen recently in an Integration test run:-

2022-03-23T23:27:10.383504172Z 2022-Month.mar-23 23:27:10,382 Fatal [SCP] - SCP context:
node-7_1  | 2022-03-23T23:27:10.383507572Z 2022-Month.mar-23 23:27:10,383 Fatal [SCP] - {
node-7_1  | 2022-03-23T23:27:10.383510772Z    "ballotProtocol" : {
node-7_1  | 2022-03-23T23:27:10.383513872Z       "ballot" : "(<null_ballot>)",
node-7_1  | 2022-03-23T23:27:10.383517272Z       "heard" : false,
node-7_1  | 2022-03-23T23:27:10.383520472Z       "phase" : "PREPARE",
node-7_1  | 2022-03-23T23:27:10.383523772Z       "state" : "i: 41 | PREPARE | b: (<null_ballot>) | p: (<null_ballot>) | p': (<null_ballot>) | h: (<null_ballot>) | c: (<null_ballot>) | M: 0"
node-7_1  | 2022-03-23T23:27:10.383527572Z    },
node-7_1  | 2022-03-23T23:27:10.383530672Z    "nomination" : {
node-7_1  | 2022-03-23T23:27:10.383533672Z       "X" : [
node-7_1  | 2022-03-23T23:27:10.383536773Z          "0x4a6984ad139681ddf70cbb2a63b6825adcfb86f8fde1077f73b264be4de019d7d4a0294c1e2a9c5eb7b4d2c5615b8514b1d33e8ecac4af8ec266071f9b181c8c",
node-7_1  | 2022-03-23T23:27:10.383540073Z          "0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b"
node-7_1  | 2022-03-23T23:27:10.383564273Z       ],
node-7_1  | 2022-03-23T23:27:10.383567573Z       "Y" : [
node-7_1  | 2022-03-23T23:27:10.383570573Z          "0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b"
node-7_1  | 2022-03-23T23:27:10.383590973Z       ],
node-7_1  | 2022-03-23T23:27:10.383594173Z       "Z" : [
node-7_1  | 2022-03-23T23:27:10.383597473Z          "0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b"
node-7_1  | 2022-03-23T23:27:10.383600974Z       ],
node-7_1  | 2022-03-23T23:27:10.383604174Z       "roundnumber" : 2,
node-7_1  | 2022-03-23T23:27:10.383607574Z       "started" : true
node-7_1  | 2022-03-23T23:27:10.383610874Z    },
node-7_1  | 2022-03-23T23:27:10.383614074Z    "statements" : [
node-7_1  | 2022-03-23T23:27:10.383617274Z       [
node-7_1  | 2022-03-23T23:27:10.383620574Z          1648078028,
node-7_1  | 2022-03-23T23:27:10.383623874Z          "{ENV@2 |  i: 41 | NOMINATE'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {} }",
node-7_1  | 2022-03-23T23:27:10.383627474Z          true
node-7_1  | 2022-03-23T23:27:10.383630774Z       ],
node-7_1  | 2022-03-23T23:27:10.383633974Z       [
node-7_1  | 2022-03-23T23:27:10.383637174Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383652674Z          "{ENV@2 |  i: 41 | NOMINATE'0x4a6984ad139681ddf70cbb2a63b6825adcfb86f8fde1077f73b264be4de019d7d4a0294c1e2a9c5eb7b4d2c5615b8514b1d33e8ecac4af8ec266071f9b181c8c' ,'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {} }",
node-7_1  | 2022-03-23T23:27:10.383656474Z          true
node-7_1  | 2022-03-23T23:27:10.383659474Z       ],
node-7_1  | 2022-03-23T23:27:10.383662474Z       [
node-7_1  | 2022-03-23T23:27:10.383665375Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383668275Z          "{ENV@3 |  i: 41 | NOMINATE'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {} }",
node-7_1  | 2022-03-23T23:27:10.383671575Z          true
node-7_1  | 2022-03-23T23:27:10.383674875Z       ],
node-7_1  | 2022-03-23T23:27:10.383677875Z       [
node-7_1  | 2022-03-23T23:27:10.383680775Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383683775Z          "{ENV@5 |  i: 41 | NOMINATE'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {} }",
node-7_1  | 2022-03-23T23:27:10.383687075Z          true
node-7_1  | 2022-03-23T23:27:10.383689975Z       ],
node-7_1  | 2022-03-23T23:27:10.383692875Z       [
node-7_1  | 2022-03-23T23:27:10.383695775Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383698775Z          "{ENV@0 |  i: 41 | NOMINATE'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {} }",
node-7_1  | 2022-03-23T23:27:10.383705775Z          true
node-7_1  | 2022-03-23T23:27:10.383708975Z       ],
node-7_1  | 2022-03-23T23:27:10.383711975Z       [
node-7_1  | 2022-03-23T23:27:10.383714875Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383717775Z          "{ENV@1 |  i: 41 | NOMINATE'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {} }",
node-7_1  | 2022-03-23T23:27:10.383721075Z          true
node-7_1  | 2022-03-23T23:27:10.383723975Z       ],
node-7_1  | 2022-03-23T23:27:10.383726975Z       [
node-7_1  | 2022-03-23T23:27:10.383729876Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383732976Z          "{ENV@2 |  i: 41 | NOMINATE'0x4a6984ad139681ddf70cbb2a63b6825adcfb86f8fde1077f73b264be4de019d7d4a0294c1e2a9c5eb7b4d2c5615b8514b1d33e8ecac4af8ec266071f9b181c8c' ,'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} }",
node-7_1  | 2022-03-23T23:27:10.383736976Z          true
node-7_1  | 2022-03-23T23:27:10.383739876Z       ],
node-7_1  | 2022-03-23T23:27:10.383742776Z       [
node-7_1  | 2022-03-23T23:27:10.383745676Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383748676Z          "{ENV@1 |  i: 41 | NOMINATE'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} }",
node-7_1  | 2022-03-23T23:27:10.383752276Z          true
node-7_1  | 2022-03-23T23:27:10.383755176Z       ],
node-7_1  | 2022-03-23T23:27:10.383758176Z       [
node-7_1  | 2022-03-23T23:27:10.383761076Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383764476Z          "{ENV@5 |  i: 41 | NOMINATE'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} }",
node-7_1  | 2022-03-23T23:27:10.383768076Z          true
node-7_1  | 2022-03-23T23:27:10.383771076Z       ],
node-7_1  | 2022-03-23T23:27:10.383773976Z       [
node-7_1  | 2022-03-23T23:27:10.383776876Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383779876Z          "{ENV@0 |  i: 41 | NOMINATE'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} }",
node-7_1  | 2022-03-23T23:27:10.383783476Z          true
node-7_1  | 2022-03-23T23:27:10.383786476Z       ],
node-7_1  | 2022-03-23T23:27:10.383789376Z       [
node-7_1  | 2022-03-23T23:27:10.383792476Z          1648078030,
node-7_1  | 2022-03-23T23:27:10.383795377Z          "{ENV@4 |  i: 41 | NOMINATE'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} | Y: {'0x7a1db2e0385d96bb5885ffc088a180260e2d53910291015ce869aaccb2e8bcf33f13a8ead194d1996a96d1f66d01f8bc069fb584dda8a40d80fd9b95e7b5995b'} }",
node-7_1  | 2022-03-23T23:27:10.383802377Z          true
node-7_1  | 2022-03-23T23:27:10.383805477Z       ]
node-7_1  | 2022-03-23T23:27:10.383808477Z    ],
node-7_1  | 2022-03-23T23:27:10.383811377Z    "validated" : true
node-7_1  | 2022-03-23T23:27:10.383814477Z }
node-7_1  | 2022-03-23T23:27:10.3846[36490](https://github.com/bosagora/agora/runs/5668617532?check_suite_focus=true#step:8:36490)Z core.exception.RangeError@source/agora/consensus/protocol/Nominator.d(1525): Range violation
node-7_1  | 2022-03-23T23:27:10.513964599Z ----------------
node-7_1  | 2022-03-23T23:27:10.514153602Z ??:? onRangeError [0x7f4987023c90]
node-7_1  | 2022-03-23T23:27:10.514279304Z ??:? _d_arraybounds [0x7f4987024370]
node-7_1  | 2022-03-23T23:27:10.515947730Z source/agora/consensus/protocol/Nominator.d:1518 /usr/local/bin/agora [0x564b04d78ed0]
mkykadir commented 2 years ago

Linked PR is merged, thus closing