codecov[bot]
commented
2 years ago Codecov Report
Merging #3226 (f214aba) into v0.x.x (52198f2) will increase coverage by
58.91%. The diff coverage is91.66%.
@@ Coverage Diff @@
## v0.x.x #3226 +/- ##
===========================================
+ Coverage 29.46% 88.38% +58.91%
===========================================
Files 265 167 -98
Lines 27046 17076 -9970
===========================================
+ Hits 7970 15092 +7122
+ Misses 19076 1984 -17092 | Flag | Coverage Δ | |
|---|---|---|
| integration | 31.71% <ø> (+2.24%) |
:arrow_up: |
| unittests | 87.40% <91.66%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| source/agora/consensus/protocol/Nominator.d | 91.92% <91.66%> (+11.76%) |
:arrow_up: |
| source/agora/common/VibeTask.d | 0.00% <0.00%> (-86.67%) |
:arrow_down: |
| source/agora/common/FileBasedLock.d | 0.00% <0.00%> (-72.73%) |
:arrow_down: |
| source/scpd/scp/SCPDriver.d | 60.00% <0.00%> (-15.00%) |
:arrow_down: |
| source/agora/node/Runner.d | 41.91% <0.00%> (-0.32%) |
:arrow_down: |
| source/agora/consensus/Quorum.d | 97.09% <0.00%> (-0.28%) |
:arrow_down: |
| source/scpd/scp/SCP.d | 100.00% <0.00%> (ø) |
|
| source/agora/crypto/Crc16.d | 100.00% <0.00%> (ø) |
|
| source/agora/consensus/data/UTXO.d | 100.00% <0.00%> (ø) |
|
| source/agora/consensus/data/Enrollment.d | 100.00% <0.00%> (ø) |
|
| ... and 308 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 52198f2...f214aba. Read the comment docs.
This will prevent the fatal SCP error and log an error with details. Although most likely this is showing that there is a bug that needs to be fixed as
combineCandidatesshould only be called with nominated tx sets the node has.