bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Nominator: Fix block interval mid-point calculation #3229

Closed omerfirmak closed 2 years ago

omerfirmak commented 2 years ago

This was a regression from when a parameter was introduced to getExpectedBlockTime().

codecov[bot] commented 2 years ago

Codecov Report

Merging #3229 (f2fd650) into v0.x.x (d4f5cb0) will increase coverage by 33.84%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           v0.x.x    #3229       +/-   ##
===========================================
+ Coverage   53.68%   87.52%   +33.84%     
===========================================
  Files         331      166      -165     
  Lines       35787    16963    -18824     
===========================================
- Hits        19212    14847     -4365     
+ Misses      16575     2116    -14459     
Flag Coverage Δ
integration 34.16% <ø> (+9.12%) :arrow_up:
unittests 87.43% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/protocol/Nominator.d 91.20% <100.00%> (ø)
source/agora/common/VibeTask.d 0.00% <0.00%> (-80.00%) :arrow_down:
source/agora/common/FileBasedLock.d 0.00% <0.00%> (-72.73%) :arrow_down:
source/agora/node/Runner.d 0.00% <0.00%> (-57.36%) :arrow_down:
source/agora/network/RPC.d 1.51% <0.00%> (-47.73%) :arrow_down:
source/agora/network/VibeManager.d 1.42% <0.00%> (-44.29%) :arrow_down:
source/agora/network/Clock.d 72.22% <0.00%> (-16.67%) :arrow_down:
source/agora/node/Config.d 69.42% <0.00%> (-11.58%) :arrow_down:
source/agora/consensus/BlockStorage.d 68.90% <0.00%> (-11.31%) :arrow_down:
source/agora/node/FullNode.d 72.42% <0.00%> (-3.94%) :arrow_down:
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4f5cb0...f2fd650. Read the comment docs.