bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 23 forks source link

EnrollmentManager: Remove some trivial wrapper #3233

Closed Geod24 closed 2 years ago

Geod24 commented 2 years ago

The diff should say it all.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3233 (772d9a8) into v0.x.x (54ec9a9) will increase coverage by 33.73%. The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           v0.x.x    #3233       +/-   ##
===========================================
+ Coverage   54.83%   88.56%   +33.73%     
===========================================
  Files         330      166      -164     
  Lines       35785    17065    -18720     
===========================================
- Hits        19622    15114     -4508     
+ Misses      16163     1951    -14212     
Flag Coverage Δ
integration 43.15% <50.00%> (+12.91%) :arrow_up:
unittests 87.39% <80.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/EnrollmentManager.d 96.96% <ø> (-0.33%) :arrow_down:
source/agora/consensus/PreImage.d 70.19% <ø> (ø)
source/agora/node/admin/AdminInterface.d 52.54% <0.00%> (ø)
source/agora/test/InvalidBlockSigByzantine.d 96.29% <ø> (ø)
source/agora/consensus/protocol/Nominator.d 91.32% <100.00%> (+0.34%) :arrow_up:
source/agora/node/Validator.d 92.96% <100.00%> (+0.39%) :arrow_up:
source/agora/test/Base.d 80.27% <100.00%> (-0.04%) :arrow_down:
source/agora/common/VibeTask.d 0.00% <0.00%> (-86.67%) :arrow_down:
source/agora/common/FileBasedLock.d 0.00% <0.00%> (-72.73%) :arrow_down:
source/agora/network/Clock.d 72.22% <0.00%> (-16.67%) :arrow_down:
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54ec9a9...772d9a8. Read the comment docs.