bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 23 forks source link

Use correct height to determine `node_id` #3236

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

When the Nominator is constructed it should take into account the ledger parameter in the constructor.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3236 (d72af73) into v0.x.x (c9fd7de) will decrease coverage by 33.62%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           v0.x.x    #3236       +/-   ##
===========================================
- Coverage   87.37%   53.75%   -33.63%     
===========================================
  Files         165      330      +165     
  Lines       16956    35778    +18822     
===========================================
+ Hits        14816    19233     +4417     
- Misses       2140    16545    +14405     
Flag Coverage Δ
integration 27.60% <100.00%> (?)
unittests 87.38% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/protocol/Nominator.d 91.13% <100.00%> (-0.55%) :arrow_down:
...ra/submodules/vibe-core/source/vibe/core/channel.d 0.00% <0.00%> (ø)
agora/submodules/vibe.d/http/vibe/http/client.d 0.24% <0.00%> (ø)
agora/submodules/vibe.d/data/vibe/data/json.d 5.78% <0.00%> (ø)
...a/submodules/vibe-core/source/vibe/internal/list.d 67.24% <0.00%> (ø)
...gora/submodules/vibe.d/http/vibe/http/fileserver.d 0.00% <0.00%> (ø)
agora/submodules/barcode/source/barcode/code39.d 0.00% <0.00%> (ø)
...ra/submodules/vibe.d/utils/vibe/utils/validation.d 0.00% <0.00%> (ø)
agora/submodules/vibe.d/inet/vibe/inet/mimetypes.d 0.00% <0.00%> (ø)
... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9fd7de...d72af73. Read the comment docs.