search

bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

Resend envelopes at exactly half block time #3245

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

Change to greater than or equals to expected block time plus half block interval. This is only to enable the unit tests to benefit from the resend as the time set is exact and does not move forwards. Although it would be nice to implement the tests to start at expected time and progress to intervals within the block time span. That is for another day.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3245 (63cfef7) into v0.x.x (c349f8e) will increase coverage by 34.04%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           v0.x.x    #3245       +/-   ##
===========================================
+ Coverage   54.63%   88.67%   +34.04%     
===========================================
  Files         332      166      -166     
  Lines       35815    17030    -18785     
===========================================
- Hits        19567    15102     -4465     
+ Misses      16248     1928    -14320
Flag Coverage Δ
integration 41.76% <100.00%> (+12.09%) :arrow_up:
unittests 87.47% <100.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/protocol/Nominator.d 91.59% <100.00%> (-0.36%) :arrow_down:
source/agora/common/VibeTask.d 0.00% <0.00%> (-86.67%) :arrow_down:
source/agora/common/FileBasedLock.d 0.00% <0.00%> (-72.73%) :arrow_down:
source/agora/consensus/BlockStorage.d 68.90% <0.00%> (-11.31%) :arrow_down:
source/agora/node/FullNode.d 74.92% <0.00%> (-1.24%) :arrow_down:
source/agora/node/Validator.d 91.45% <0.00%> (-0.51%) :arrow_down:
source/agora/consensus/state/Ledger.d 89.93% <0.00%> (-0.34%) :arrow_down:
source/agora/consensus/EnrollmentManager.d 96.85% <0.00%> (-0.32%) :arrow_down:
source/agora/script/Engine.d 97.59% <0.00%> (-0.16%) :arrow_down:
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c349f8e...63cfef7. Read the comment docs.