Codecov Report

Merging #3250 (6a3c0bf) into v0.x.x (c349f8e) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           v0.x.x    #3250      +/-   ##
==========================================
- Coverage   54.63%   54.61%   -0.03%     
==========================================
  Files         332      331       -1     
  Lines       35815    35812       -3     
==========================================
- Hits        19567    19557      -10     
- Misses      16248    16255       +7

Flag	Coverage Δ
integration	`29.53% <ø> (-0.14%)`	:arrow_down:
unittests	`87.83% <ø> (+0.32%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
source/agora/node/main.d	`44.85% <ø> (ø)`
source/agora/node/Runner.d	`40.52% <0.00%> (-15.04%)`	:arrow_down:
...gora/submodules/dtext/source/dtext/log/Hierarchy.d	`81.35% <0.00%> (-3.89%)`	:arrow_down:
...ntcore/source/eventcore/internal/consumablequeue.d	`70.27% <0.00%> (-2.71%)`	:arrow_down:
source/agora/consensus/protocol/Nominator.d	`90.87% <0.00%> (-1.08%)`	:arrow_down:
...eventcore/source/eventcore/drivers/posix/sockets.d	`47.03% <0.00%> (-0.38%)`	:arrow_down:
source/agora/node/FullNode.d	`75.85% <0.00%> (-0.31%)`	:arrow_down:
source/agora/stats/Stats.d	`100.00% <0.00%> (ø)`
agora/submodules/dtext/source/dtext/log/ILogger.d	`0.00% <0.00%> (ø)`
agora/submodules/vibe-core/source/vibe/core/net.d	`62.28% <0.00%> (ø)`
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c349f8e...6a3c0bf. Read the comment docs.

Geod24 commented 2 years ago

Few things w.r.t. the submodule:

Why does it include a copy of (C++) Tracy ? I'd say a submodule would be better. Best would be if there was a way to install tracy as a lib with a pkg-config file.
Needs LICENSE (MIT);
I would not expose package.d. One of the reason is that it's just an alias to API, the second is that top level modules tend to get in the way. E.g.:
```
module writeln;
```

import std.stdio;

void main () { writeln("Does not compile");
}



That's why I recommend [vanity packages](https://forum.dlang.org/thread/jdkmtgftmwtwaxxqhlju@forum.dlang.org).

mkykadir commented 2 years ago

Why does it include a copy of (C++) Tracy ? I'd say a submodule would be better. Best would be if there was a way to install tracy as a lib with a pkg-config file.

I pass over that intentionally for not creating a git dependency to build library but currently it depends on a lot already.

Needs LICENSE (MIT);

Added

bosagora / agora

Move Tracy into its own submodule #3250

Codecov Report