Closed hewison-chris closed 2 years ago
Merging #3256 (38ef22d) into v0.x.x (d782bfe) will decrease coverage by
32.92%
. The diff coverage is81.48%
.
@@ Coverage Diff @@
## v0.x.x #3256 +/- ##
===========================================
- Coverage 87.76% 54.84% -32.93%
===========================================
Files 164 331 +167
Lines 16963 35874 +18911
===========================================
+ Hits 14888 19675 +4787
- Misses 2075 16199 +14124
Flag | Coverage Δ | |
---|---|---|
integration | 30.02% <0.00%> (-12.96%) |
:arrow_down: |
unittests | 87.51% <81.48%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
source/agora/utils/PrettyPrinter.d | 99.18% <ø> (ø) |
|
source/agora/utils/TxBuilder.d | 96.83% <79.16%> (-1.75%) |
:arrow_down: |
source/agora/utils/Test.d | 92.66% <100.00%> (+0.20%) |
:arrow_up: |
source/agora/flash/Node.d | 80.67% <0.00%> (-0.22%) |
:arrow_down: |
source/agora/consensus/state/Ledger.d | 90.26% <0.00%> (ø) |
|
agora/submodules/vibe.d/web/vibe/web/auth.d | 0.00% <0.00%> (ø) |
|
...submodules/vibe-core/source/vibe/internal/string.d | 0.00% <0.00%> (ø) |
|
...submodules/vibe.d/http/vibe/http/auth/basic_auth.d | 0.00% <0.00%> (ø) |
|
agora/submodules/barcode/source/barcode/types.d | 0.00% <0.00%> (ø) |
|
... and 179 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d782bfe...38ef22d. Read the comment docs.
Should #3238 be closed, then?
Should #3238 be closed, then?
Yes, it can now. I only kept both yesterday in case Mathias had anything to push. Is fine to be closed now though.
Taken from https://github.com/bosagora/agora/pull/3238 The last step missing to allow the TxBuilder to be truly independent from the Well-Known keys, yet offer a similar API.