bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 22 forks source link

De-couple TxBuilder from WK.Keys #3258

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

Trying a different approach as the changes in PR https://github.com/bosagora/agora/pull/3256 sometimes causes a segmentation fault when the unit tests run.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3258 (48ae865) into v0.x.x (be3c176) will decrease coverage by 0.87%. The diff coverage is 98.24%.

@@            Coverage Diff             @@
##           v0.x.x    #3258      +/-   ##
==========================================
- Coverage   88.56%   87.68%   -0.88%     
==========================================
  Files         166      165       -1     
  Lines       17037    16929     -108     
==========================================
- Hits        15088    14845     -243     
- Misses       1949     2084     +135     
Flag Coverage Δ
integration ?
unittests 87.68% <98.24%> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/cli/client/GenTxProcess.d 0.00% <0.00%> (ø)
source/agora/test/Fee.d 96.66% <ø> (ø)
source/agora/consensus/BlockStorage.d 72.79% <100.00%> (+3.88%) :arrow_up:
source/agora/consensus/Ledger.d 97.53% <100.00%> (ø)
source/agora/consensus/validation/Block.d 96.97% <100.00%> (ø)
source/agora/test/BanManager.d 94.00% <100.00%> (ø)
source/agora/test/Base.d 80.99% <100.00%> (ø)
source/agora/test/Ledger.d 95.55% <100.00%> (ø)
source/agora/test/LockHeight.d 96.15% <100.00%> (ø)
source/agora/test/NetworkManager.d 97.22% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be3c176...48ae865. Read the comment docs.

hewison-chris commented 2 years ago

Found solution in other branch.