TxBuilder: Remove hard dependency to WellKnown keys

bosagora / agora

POC Node implementation for CoinNet

https://bosagora.io

MIT License

37 stars 23 forks source link

TxBuilder: Remove hard dependency to WellKnown keys #3270

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

A different approach to PR https://github.com/bosagora/agora/pull/3256. The last step missing to allow the TxBuilder to be truly independent from the Well-Known keys, yet offer a similar API.

omerfirmak commented 2 years ago

Yeap, this is what I had in mind. It is a bummer we still need to forward those ctors tho.

hewison-chris commented 2 years ago

In the end using an Abstract class for the Builder does not really help. I have another PR https://github.com/bosagora/agora/pull/3274 which I think is the best solution I have so far which helps with the various unlock functions we use in the tests.