hewison-chris commented 2 years ago

Currently it is confusing how the unlocking will occur for the different lock types.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3274 (d4eb93a) into v0.x.x (3656186) will decrease coverage by 1.28%. The diff coverage is 97.00%.

@@            Coverage Diff             @@
##           v0.x.x    #3274      +/-   ##
==========================================
- Coverage   88.76%   87.47%   -1.29%     
==========================================
  Files         165      164       -1     
  Lines       17083    16987      -96     
==========================================
- Hits        15163    14860     -303     
- Misses       1920     2127     +207

Flag	Coverage Δ
integration	`?`
unittests	`87.47% <97.00%> (-0.15%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
source/agora/cli/client/GenTxProcess.d	`0.00% <0.00%> (ø)`
source/agora/test/Fee.d	`96.66% <ø> (ø)`
source/agora/utils/TxBuilder.d	`98.69% <95.65%> (+1.86%)`	:arrow_up:
source/agora/consensus/BlockStorage.d	`68.90% <100.00%> (-6.72%)`	:arrow_down:
source/agora/consensus/Ledger.d	`97.53% <100.00%> (ø)`
source/agora/consensus/validation/Block.d	`96.97% <100.00%> (ø)`
source/agora/test/BanManager.d	`94.00% <100.00%> (ø)`
source/agora/test/Base.d	`80.99% <100.00%> (ø)`
source/agora/test/Ledger.d	`95.55% <100.00%> (ø)`
source/agora/test/LockHeight.d	`96.15% <100.00%> (ø)`
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3656186...d4eb93a. Read the comment docs.

hewison-chris commented 2 years ago

Closing this for now as the tests are running slower with this implementation and it is not needed currently.

bosagora / agora

Refactor TxBuilder to improve unlock logic #3274

Codecov Report