bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 23 forks source link

Engine: Implement OP.HASH_SHA256 #3285

Closed omerfirmak closed 2 years ago

omerfirmak commented 2 years ago

for interoperability with our Ethereum token.

Fixes #3284

codecov[bot] commented 2 years ago

Codecov Report

Merging #3285 (041ec6d) into v0.x.x (c4769ec) will increase coverage by 0.07%. The diff coverage is 86.66%.

:exclamation: Current head 041ec6d differs from pull request most recent head f6d3a20. Consider uploading reports for the commit f6d3a20 to get more accurate results

@@            Coverage Diff             @@
##           v0.x.x    #3285      +/-   ##
==========================================
+ Coverage   88.11%   88.18%   +0.07%     
==========================================
  Files         164      164              
  Lines       16934    16951      +17     
==========================================
+ Hits        14921    14948      +27     
+ Misses       2013     2003      -10     
Flag Coverage Δ
integration 43.56% <ø> (+1.95%) :arrow_up:
unittests 87.90% <86.66%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/script/Opcodes.d 100.00% <ø> (ø)
source/agora/script/Engine.d 97.49% <86.66%> (-0.10%) :arrow_down:
source/scpd/scp/SCPDriver.d 60.00% <0.00%> (-15.00%) :arrow_down:
source/agora/common/Task.d 88.88% <0.00%> (-11.12%) :arrow_down:
source/agora/network/Client.d 88.23% <0.00%> (-5.05%) :arrow_down:
source/agora/consensus/Ledger.d 97.55% <0.00%> (+0.14%) :arrow_up:
source/agora/network/Manager.d 78.48% <0.00%> (+0.63%) :arrow_up:
source/agora/consensus/state/Ledger.d 90.72% <0.00%> (+0.66%) :arrow_up:
source/agora/consensus/protocol/Nominator.d 91.63% <0.00%> (+0.71%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4769ec...f6d3a20. Read the comment docs.