bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 23 forks source link

Trivial: Improve fail logging for GossipProtocol test #3291

Closed mkykadir closed 2 years ago

mkykadir commented 2 years ago

Log the address of the failed node.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3291 (3f9a71b) into v0.x.x (f7ccda5) will increase coverage by 0.85%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           v0.x.x    #3291      +/-   ##
==========================================
+ Coverage   87.92%   88.78%   +0.85%     
==========================================
  Files         164      165       +1     
  Lines       16951    17063     +112     
==========================================
+ Hits        14905    15150     +245     
+ Misses       2046     1913     -133     
Flag Coverage Δ
integration 47.65% <ø> (?)
unittests 87.63% <83.33%> (-0.30%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/test/GossipProtocol.d 86.11% <83.33%> (-7.83%) :arrow_down:
source/agora/consensus/BlockStorage.d 68.90% <0.00%> (-8.49%) :arrow_down:
source/agora/network/Client.d 88.23% <0.00%> (-5.05%) :arrow_down:
source/agora/consensus/protocol/Nominator.d 90.92% <0.00%> (-1.07%) :arrow_down:
source/agora/consensus/state/Ledger.d 89.73% <0.00%> (-1.00%) :arrow_down:
source/agora/node/Validator.d 91.45% <0.00%> (-0.97%) :arrow_down:
source/agora/test/Flash.d 95.12% <0.00%> (-0.11%) :arrow_down:
source/agora/network/Manager.d 78.48% <0.00%> (ø)
source/agora/node/main.d 44.85% <0.00%> (ø)
source/agora/node/FullNode.d 75.23% <0.00%> (+1.85%) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7ccda5...3f9a71b. Read the comment docs.