search

bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
36 stars 22 forks source link

Root log is not propagated to console #3295

Closed mkykadir closed 2 years ago

mkykadir commented 2 years ago

Even following config, logs are not displayed on console; since #3243 

logging:
  root:
    level: Info
    console: true
    file: log/root.log
linked0 commented 2 years ago

I have used the additive: true for the problem, it is just a workaround tho.

mkykadir commented 2 years ago

I have used the additive: true for the problem, it is just a workaround tho.

Yeah, I don't know if this is an undocumented change in behavior but; this causes

mkykadir commented 2 years ago

Likewise, setting the root logger as additive most likely means child loggers should be additive too, hence propagating all options make more sense.

I believe there was a behavioral change thus, additive is required by default now. We can close this or reconsider. What are your thoughts? @hewison-chris

hewison-chris commented 2 years ago

Likewise, setting the root logger as additive most likely means child loggers should be additive too, hence propagating all options make more sense.

I believe there was a behavioral change thus, additive is required by default now. We can close this or reconsider. What are your thoughts? @hewison-chris

Perhaps the default should be additive so that it behaves as expected.