bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 23 forks source link

Network unit tests should advance network time half way through timeout #3298

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

To better simulate the real life behavior the mock clock used in base.d should first be set to the time for block nomination and after half the timeout allocated to externalize it should be set to half way through the block interval time. This is because we resend envelopes at this point to try and ensure all nodes can progress with consensus. They may have been offline or not received the envelopes when gossiped the first time.