bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
36 stars 22 forks source link

Network unit tests: Advance clock during the test #3299

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

Fixes issue #3298 .

codecov[bot] commented 2 years ago

Codecov Report

Merging #3299 (c19f685) into v0.x.x (ef399df) will increase coverage by 0.27%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           v0.x.x    #3299      +/-   ##
==========================================
+ Coverage   88.79%   89.07%   +0.27%     
==========================================
  Files         165      165              
  Lines       17063    17069       +6     
==========================================
+ Hits        15151    15204      +53     
+ Misses       1912     1865      -47     
Flag Coverage Δ
integration 47.71% <ø> (+7.83%) :arrow_up:
unittests 87.83% <100.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/test/Base.d 80.70% <100.00%> (+0.22%) :arrow_up:
source/agora/node/Validator.d 91.95% <0.00%> (-1.01%) :arrow_down:
source/agora/consensus/state/Ledger.d 90.06% <0.00%> (-0.67%) :arrow_down:
source/agora/flash/Node.d 80.67% <0.00%> (-0.43%) :arrow_down:
source/agora/node/FullNode.d 76.47% <0.00%> (+0.30%) :arrow_up:
source/agora/consensus/protocol/Nominator.d 91.45% <0.00%> (+0.53%) :arrow_up:
source/agora/network/Manager.d 77.84% <0.00%> (+0.63%) :arrow_up:
source/agora/node/Registry.d 79.37% <0.00%> (+2.08%) :arrow_up:
source/agora/node/Config.d 76.64% <0.00%> (+8.02%) :arrow_up:
source/agora/node/Runner.d 55.55% <0.00%> (+15.03%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef399df...c19f685. Read the comment docs.

hewison-chris commented 2 years ago

It didn't catch the AssertError. Will update.

hewison-chris commented 2 years ago

Updated to catch Throwable which will catch AssertError.