Closed hewison-chris closed 2 years ago
Does this PR happen to reduce a duplicated string like the following message?
Info [agora.consensus.protocol.Nominator] - agora.consensus.protocol.Nominator.Nominator.nominate(): Proposing tx set for slot 282, ledger is at height 281
Does this PR happen to reduce a duplicated string like the following message?
Info [agora.consensus.protocol.Nominator] - agora.consensus.protocol.Nominator.Nominator.nominate(): Proposing tx set for slot 282, ledger is at height 281
Yes the second commit removes the function name being added to those log lines.
Merging #3301 (a7c6fa5) into v0.x.x (be9b8d1) will increase coverage by
0.88%
. The diff coverage is73.13%
.
@@ Coverage Diff @@
## v0.x.x #3301 +/- ##
==========================================
+ Coverage 87.83% 88.72% +0.88%
==========================================
Files 164 165 +1
Lines 16964 17074 +110
==========================================
+ Hits 14901 15149 +248
+ Misses 2063 1925 -138
Flag | Coverage Δ | |
---|---|---|
integration | 42.67% <71.42%> (?) |
|
unittests | 87.77% <73.13%> (-0.07%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
source/agora/consensus/state/Ledger.d | 88.85% <0.00%> (-0.66%) |
:arrow_down: |
source/agora/test/ValidatorRecurringEnrollment.d | 94.23% <0.00%> (ø) |
|
source/agora/network/Manager.d | 77.84% <50.00%> (+0.63%) |
:arrow_up: |
source/agora/node/FullNode.d | 74.30% <69.23%> (+1.54%) |
:arrow_up: |
source/agora/node/Validator.d | 91.45% <75.00%> (-0.47%) |
:arrow_down: |
source/agora/consensus/protocol/Nominator.d | 91.29% <75.60%> (-0.36%) |
:arrow_down: |
source/agora/node/TransactionRelayer.d | 89.28% <100.00%> (ø) |
|
source/agora/test/BlockRewards.d | 95.23% <100.00%> (ø) |
|
source/agora/test/PeriodicCatchup.d | 96.55% <100.00%> (ø) |
|
source/agora/utils/Log.d | 62.50% <100.00%> (+5.26%) |
:arrow_up: |
... and 15 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update be9b8d1...a7c6fa5. Read the comment docs.
Is it right to include the files of submodule/dtext
in the first commit?
Is it right to include the files of
submodule/dtext
in the first commit?
The dtext submodule update is needed to enable the FunctionOrigin option for Logger.
I updated the bosagora/dtext to avoid adding deprecation warnings during the Agora build.
source/dtext/format/Integer_tango.d(111,32): Deprecation: integral promotion not done for `-i_`, use '-preview=intpromote' switch or `-cast(int)(i_)`
Fixes issue #3300.