bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
36 stars 22 forks source link

Trivial: Use `createTimer` for Client gossip timer #3306

Closed mkykadir closed 2 years ago

mkykadir commented 2 years ago

It is immediately stopped after setting, createTimer is more suitable for those conditions.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3306 (82c5e2c) into v0.x.x (be9b8d1) will increase coverage by 0.70%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           v0.x.x    #3306      +/-   ##
==========================================
+ Coverage   87.83%   88.54%   +0.70%     
==========================================
  Files         164      165       +1     
  Lines       16964    17073     +109     
==========================================
+ Hits        14901    15117     +216     
+ Misses       2063     1956     -107     
Flag Coverage Δ
integration 34.71% <100.00%> (?)
unittests 87.57% <100.00%> (-0.27%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/network/Client.d 85.59% <100.00%> (-2.65%) :arrow_down:
source/agora/common/Task.d 88.88% <0.00%> (-11.12%) :arrow_down:
source/agora/consensus/BlockStorage.d 68.90% <0.00%> (-8.49%) :arrow_down:
source/agora/consensus/protocol/Nominator.d 90.58% <0.00%> (-1.07%) :arrow_down:
source/agora/node/Validator.d 90.95% <0.00%> (-0.97%) :arrow_down:
source/agora/consensus/state/Ledger.d 88.85% <0.00%> (-0.66%) :arrow_down:
source/agora/flash/Node.d 80.67% <0.00%> (-0.43%) :arrow_down:
source/agora/consensus/Ledger.d 97.41% <0.00%> (-0.15%) :arrow_down:
source/agora/network/Manager.d 77.21% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be9b8d1...82c5e2c. Read the comment docs.