Closed mkykadir closed 2 years ago
Merging #3307 (ffb3747) into v0.x.x (3ad1781) will increase coverage by
1.04%
. The diff coverage is67.74%
.
@@ Coverage Diff @@
## v0.x.x #3307 +/- ##
==========================================
+ Coverage 87.88% 88.92% +1.04%
==========================================
Files 164 165 +1
Lines 16975 17108 +133
==========================================
+ Hits 14918 15213 +295
+ Misses 2057 1895 -162
Flag | Coverage Δ | |
---|---|---|
integration | 37.14% <60.00%> (+0.29%) |
:arrow_up: |
unittests | 87.73% <46.15%> (+0.13%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
source/agora/api/FullNode.d | 100.00% <ø> (ø) |
|
source/agora/node/FullNode.d | 74.10% <ø> (+2.08%) |
:arrow_up: |
source/agora/network/Client.d | 86.88% <50.00%> (-1.26%) |
:arrow_down: |
source/agora/network/Manager.d | 77.28% <50.00%> (+0.60%) |
:arrow_up: |
source/agora/network/RPC.d | 54.36% <50.00%> (+52.34%) |
:arrow_up: |
source/agora/node/main.d | 45.94% <60.00%> (ø) |
|
source/agora/network/VibeManager.d | 50.00% <100.00%> (+48.55%) |
:arrow_up: |
source/agora/test/Base.d | 80.88% <100.00%> (+0.18%) |
:arrow_up: |
source/agora/script/Engine.d | 97.34% <0.00%> (-0.15%) |
:arrow_down: |
... and 13 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3ad1781...ffb3747. Read the comment docs.
Towards a better shutdown procedure
This will reduce the number of eventcore leaks during shutdown, only DNS UDP connection will be remaining as leaking.
Part of #3158
depends on #3311 and https://github.com/bosagora/localrest/pull/6