search

bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 23 forks source link

Remove for each wrapping the map function #3309

Closed hewison-chris closed 2 years ago

hewison-chris commented 2 years ago

Before refactor I ran :

while dtest=test.ValidatorCleanRestart dub test ; do :; done > log/cleanRestart.log

and it hit the popFront on empty map assertion after 4 runs.

After refactor it ran over 20 times without assertion.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3309 (1d9ed81) into v0.x.x (03f36b7) will decrease coverage by 0.95%. The diff coverage is 91.66%.

@@            Coverage Diff             @@
##           v0.x.x    #3309      +/-   ##
==========================================
- Coverage   89.02%   88.06%   -0.96%     
==========================================
  Files         165      164       -1     
  Lines       17071    16961     -110     
==========================================
- Hits        15197    14937     -260     
- Misses       1874     2024     +150
Flag Coverage Δ
integration 27.97% <ø> (-8.20%) :arrow_down:
unittests 87.78% <91.66%> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/network/Manager.d 76.82% <91.66%> (-1.34%) :arrow_down:
source/agora/node/Runner.d 0.00% <0.00%> (-55.56%) :arrow_down:
source/agora/network/RPC.d 2.02% <0.00%> (-52.53%) :arrow_down:
source/agora/network/VibeManager.d 1.44% <0.00%> (-46.38%) :arrow_down:
source/agora/network/Clock.d 72.22% <0.00%> (-16.67%) :arrow_down:
source/agora/node/FullNode.d 72.44% <0.00%> (-4.03%) :arrow_down:
source/agora/node/Config.d 64.96% <0.00%> (-3.65%) :arrow_down:
source/agora/node/Registry.d 77.29% <0.00%> (-2.09%) :arrow_down:
source/agora/node/Validator.d 90.90% <0.00%> (-2.06%) :arrow_down:
source/agora/consensus/state/Ledger.d 88.85% <0.00%> (-1.32%) :arrow_down:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03f36b7...1d9ed81. Read the comment docs.