bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 23 forks source link

DB: Move SQLite config into ManagedDatabase #3321

Closed mkykadir closed 2 years ago

mkykadir commented 2 years ago

It was configured in TransactionPool, which felt wrong.

Fixes #2822

codecov[bot] commented 2 years ago

Codecov Report

Merging #3321 (5ab07dc) into v0.x.x (a9ee679) will increase coverage by 0.40%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           v0.x.x    #3321      +/-   ##
==========================================
+ Coverage   87.51%   87.92%   +0.40%     
==========================================
  Files         164      164              
  Lines       17018    17016       -2     
==========================================
+ Hits        14894    14961      +67     
+ Misses       2124     2055      -69     
Flag Coverage Δ
integration 42.89% <ø> (?)
unittests 87.64% <66.66%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/pool/Transaction.d 93.89% <ø> (+0.19%) :arrow_up:
source/agora/common/ManagedDatabase.d 86.66% <66.66%> (-5.00%) :arrow_down:
source/agora/node/FullNode.d 70.83% <0.00%> (-1.20%) :arrow_down:
source/agora/node/Validator.d 90.90% <0.00%> (-1.02%) :arrow_down:
source/agora/consensus/state/Ledger.d 88.85% <0.00%> (-0.99%) :arrow_down:
source/agora/network/Manager.d 76.34% <0.00%> (-0.32%) :arrow_down:
source/agora/script/Engine.d 97.34% <0.00%> (-0.15%) :arrow_down:
source/agora/consensus/protocol/Nominator.d 92.18% <0.00%> (+1.24%) :arrow_up:
source/agora/test/NetworkDiscovery.d 88.63% <0.00%> (+4.54%) :arrow_up:
source/agora/utils/Log.d 62.50% <0.00%> (+5.00%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9ee679...5ab07dc. Read the comment docs.