bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 23 forks source link

RPC: Write lock Shared TCPConnection #3322

Closed mkykadir closed 2 years ago

mkykadir commented 2 years ago

Write is invoked before previous write operation without a concurrency lock; which caused nodes to core-dump with Overwriting notification callback.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3322 (89c535a) into v0.x.x (a9ee679) will increase coverage by 1.15%. The diff coverage is 100.00%.

:exclamation: Current head 89c535a differs from pull request most recent head 5b928c0. Consider uploading reports for the commit 5b928c0 to get more accurate results

@@            Coverage Diff             @@
##           v0.x.x    #3322      +/-   ##
==========================================
+ Coverage   87.51%   88.66%   +1.15%     
==========================================
  Files         164      165       +1     
  Lines       17018    17131     +113     
==========================================
+ Hits        14894    15190     +296     
+ Misses       2124     1941     -183     
Flag Coverage Δ
integration 40.56% <100.00%> (?)
unittests 87.64% <0.00%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/network/RPC.d 55.23% <100.00%> (+53.29%) :arrow_up:
source/agora/common/ManagedDatabase.d 86.66% <0.00%> (-5.00%) :arrow_down:
source/agora/consensus/state/Ledger.d 89.50% <0.00%> (-0.33%) :arrow_down:
source/agora/node/main.d 45.94% <0.00%> (ø)
source/agora/consensus/pool/Transaction.d 93.89% <0.00%> (+0.19%) :arrow_up:
source/agora/node/Validator.d 92.46% <0.00%> (+0.54%) :arrow_up:
source/agora/node/FullNode.d 72.61% <0.00%> (+0.59%) :arrow_up:
source/agora/consensus/protocol/Nominator.d 91.65% <0.00%> (+0.71%) :arrow_up:
source/agora/network/Manager.d 78.54% <0.00%> (+1.89%) :arrow_up:
source/agora/node/Config.d 68.61% <0.00%> (+3.64%) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9ee679...5b928c0. Read the comment docs.