bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
37 stars 23 forks source link

DNS: Remove seed configuration #3323

Closed mkykadir closed 2 years ago

mkykadir commented 2 years ago

Fixes #2256

Registry answers for seed queries since #3320 and NetworkManager adds addresses from node registry for initial peer finding already. This configuration field is not needed anymore.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3323 (34f5a2d) into v0.x.x (a9ee679) will increase coverage by 1.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           v0.x.x    #3323      +/-   ##
==========================================
+ Coverage   87.51%   88.56%   +1.04%     
==========================================
  Files         164      165       +1     
  Lines       17018    17112      +94     
==========================================
+ Hits        14894    15155     +261     
+ Misses       2124     1957     -167     
Flag Coverage Δ
integration 28.30% <ø> (?)
unittests 87.62% <ø> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/network/Manager.d 82.88% <ø> (+6.22%) :arrow_up:
source/agora/node/Config.d 75.18% <ø> (+10.21%) :arrow_up:
source/agora/node/main.d 45.94% <ø> (ø)
source/agora/common/ManagedDatabase.d 86.66% <0.00%> (-5.00%) :arrow_down:
source/agora/consensus/protocol/Nominator.d 91.11% <0.00%> (+0.17%) :arrow_up:
source/agora/consensus/pool/Transaction.d 93.89% <0.00%> (+0.19%) :arrow_up:
source/agora/node/Validator.d 92.96% <0.00%> (+1.04%) :arrow_up:
source/agora/node/Registry.d 77.93% <0.00%> (+1.98%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9ee679...34f5a2d. Read the comment docs.