bosagora / agora

POC Node implementation for CoinNet
https://bosagora.io
MIT License
36 stars 22 forks source link

dub.json: Allow LDC v1.29 and above #3328

Closed Geod24 closed 2 years ago

Geod24 commented 2 years ago

Using '~>1.28.1' means '>=1.28.1' && '<1.29.0', which is not what we want.

codecov[bot] commented 2 years ago

Codecov Report

Merging #3328 (4a5856a) into v0.x.x (a3223f9) will increase coverage by 1.13%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           v0.x.x    #3328      +/-   ##
==========================================
+ Coverage   87.53%   88.66%   +1.13%     
==========================================
  Files         164      165       +1     
  Lines       16999    17110     +111     
==========================================
+ Hits        14880    15171     +291     
+ Misses       2119     1939     -180     
Flag Coverage Δ
integration 42.40% <ø> (?)
unittests 87.68% <ø> (+0.14%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/consensus/Ledger.d 97.41% <0.00%> (-0.15%) :arrow_down:
source/agora/node/main.d 45.94% <0.00%> (ø)
source/agora/consensus/protocol/Nominator.d 91.47% <0.00%> (+0.53%) :arrow_up:
source/agora/node/Validator.d 91.45% <0.00%> (+0.54%) :arrow_up:
source/agora/network/Manager.d 81.87% <0.00%> (+1.00%) :arrow_up:
source/agora/node/FullNode.d 72.61% <0.00%> (+2.08%) :arrow_up:
source/agora/node/Config.d 68.61% <0.00%> (+3.64%) :arrow_up:
source/agora/test/NetworkDiscovery.d 88.63% <0.00%> (+4.54%) :arrow_up:
source/agora/utils/Log.d 62.50% <0.00%> (+5.00%) :arrow_up:
source/agora/consensus/BlockStorage.d 75.61% <0.00%> (+6.71%) :arrow_up:
... and 5 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Geod24 commented 2 years ago

Looks like the CI is broken @mkykadir @omerfirmak

Geod24 commented 2 years ago

This will need https://github.com/bosagora/serialization/pull/25 to move forward. CC @hewison-chris .

Geod24 commented 2 years ago

Looks like it did the trick.

Geod24 commented 2 years ago

@hewison-chris : Can you re-enable automerge ? More fixes coming.