Ensure NRVO is done through the Deserializer to avoid memory corruption

bosagora / agora

POC Node implementation for CoinNet

https://bosagora.io

MIT License

36 stars 22 forks source link

Ensure NRVO is done through the Deserializer to avoid memory corruption #691

Open Geod24 opened 4 years ago

Geod24 commented 4 years ago

We plan to expand the usage of the serializer to be used for network communication. Currently we are using the less-than-ideal JSON approach, which adds a lot of overhead. However, due to concerns about efficiency and internal pointers (e.g. std::string), the deserializer should not perform any unwarranted move.

DoD:

[ ] There is an utility that test if a type is moving during deserialization;
[ ] Tests are added so that SCPEnvelope is not moved;

Geod24 commented 3 years ago

This is testing only, and we know it works, so changing the milestone.