search

bosch-engineering / off_highway_sensor_drivers

This project provides ROS drivers for Bosch Off-Highway sensor systems. (Radar Off-Highway Premium, Radar OHW, General Purpose Radar Off-Highway (GPR), Ultrasonic Sensor System OHW Entry & Premium)
Other
48 stars 13 forks source link

Binary releases to the ROS buildfarm #2

Open Timple opened 8 months ago

Timple commented 8 months ago

Thank you for creating these drivers!

Would it be possible to distribute them to the ROS buildfarm? Using bloom for the current active ROS2 distributions?

daniel4ohw commented 7 months ago

Hello @Timple, thank you very much for your feedback. Of course it is the easiest for the users if the packages are built by the ROS buildfarm. We are planning to realize this, but we still have issues that have a higher priority. We will try to do it soon. Greetings Daniel

daniel4ohw commented 6 months ago

Hello @Timple, Good news. Today we created the pull request to include our packages in the ROS build farm. Hopefully the review will be processed quickly. PR rosdistro Best regards Daniel

Timple commented 6 months ago

Awesome! Although we're using iron at the moment :slightly_smiling_face:

daniel4ohw commented 6 months ago

@Timple which sensor are you using?

Timple commented 6 months ago

We're using the off_highway_radar package

daniel4ohw commented 6 months ago

Hi @Timple we still have to wait with the build farm integration. We are currently working on changes that will result in changes to the API/ABI.... Additionally as of now we will primarily support LTS distributions.

Timple commented 2 months ago

Well, in that case, we're already in the process of migrating towards Jazzy :sunglasses:

I believe the changes you desired are already performed?

daniel4ohw commented 2 months ago

Apologies for the delay in updating you. I’m pleased to share that, as of the end of last week, our package is now available for testing. https://repo.ros2.org/status_page/humble_default.html?q=off-highway

daniel4ohw commented 2 months ago

@Timple We test our node from time to time with rolling. Unfortunately, we can currently only support one distribution. Are you experiencing any issues with Jazzy?

Timple commented 2 months ago

It builds fine from source. So I don't see a reason to only support one distribution :slightly_smiling_face:. As the codebase actually stays identical.

daniel4ohw commented 2 months ago

For us, it is mainly the testing effort. But we are working on improving it....

Timple commented 2 months ago

Fair enough. Shouldn't testing be done on the latest LTS? :wink:

But I understand, we'll wait it out.

Timple commented 2 months ago

For what it's worth: since #9 this package is able to compile on the buildfarm. So the same humble-devel branch can be released on jazzy without maintaining a duplicate codebase.