search

bosch-engineering / off_highway_sensor_drivers

This project provides ROS drivers for Bosch Off-Highway sensor systems. (Radar Off-Highway Premium, Radar OHW, General Purpose Radar Off-Highway (GPR), Ultrasonic Sensor System OHW Entry & Premium)
Other
49 stars 13 forks source link

Fix azimuth and elevation variances #8

Closed maxhilger closed 4 months ago

maxhilger commented 4 months ago

Hello,

I noticed that the elevation and azimuth angle variances are switched in the point cloud definition. This bug is fixed within this PR. Additionally, the longer boost MPL vector is no longer necessary after removing the normals in the point cloud.

shu-beg commented 4 months ago

Hi @maxhilger, thanks for contributing, I will have a look into your changes. In the meanwhile, could you please sign-off your commit and rephrase your commit message according to the rules described here (capitalize subject line, use imperative mood)?

maxhilger commented 4 months ago

Hi @shu-beg Thanks for having a look into it. I signed off and rephrased the commit now, hopefully everything is correct now.