search

bosch-thermostat / bosch-thermostat-client-python

Python3 asyncio package to talk to Bosch thermostat devices.
Apache License 2.0
23 stars 20 forks source link

CT200: Move dhw1 openWindowDetectionStatus to zone circuit #38

Closed rikroe closed 9 months ago

rikroe commented 1 year ago

This PR moves openWindowDetectionStatus from all easycontrol water heater (dhw1) to the zone zn1 circuits.

This reduces unecessary logging in Home Assistant, as the id is not found on the gateway.

Fixes https://github.com/bosch-thermostat/home-assistant-bosch-custom-component/issues/323. Above issue also includes a debug scan showing the status only available in /zones/zn1/openWindowDetection/status.

pszafer commented 1 year ago

Are you sure that nobody has this sensor attached? We'd need to collect some logs. If somebody has it then we would need to avoid unnecessary fetch in different way

rikroe commented 1 year ago

Just updated the code because it doesn't make sense to remove and it should be in the zone circuit.

Also water heaters usually are not impacted by open windows - heating circuits or zones, yes. But a water heater that just boils for showering or warm water?

pszafer commented 1 year ago

Thanks, I'll check it next week and let you know. I don't know why I put it under water heater. Probably a typo