search

bosch-thermostat / home-assistant-bosch-custom-component

HA custom component for Bosch thermostats
Apache License 2.0
231 stars 46 forks source link

Integration is using deprecated `DEVICE_CLASS_*` constants #250

Closed frenck closed 1 year ago

frenck commented 1 year ago

Describe the bug

This custom integration uses deprecated DEVICE_CLASS_* constants in its codebase.

The DEVICE_CLASS_* constants have been deprecated and replaced in Home Assistant Core 2021.12 (over a year ago). I would highly suggest updating/migrating this integration to the new enums.

For example, for the device classes supported by the sensor platform, there is now a SensorDeviceClass enum. So if a sensor previously used the DEVICE_CLASS_ENERGY constant, it should now use SensorDeviceClass.ENERGY. Other platforms (like binary_sensor, and number) provide similar enumerations for their supported device classes.

The migration thus only consists of replacing constants with an enumeration member and is, therefore, very low impact and should be fairly straightforward.

If I can help resolve any questions regarding this change or migration, feel free to ask or respond to this issue. I'm happy to help!

Kindest regards,

../Frenck

To Reproduce n/a

Expected behavior n/a

Screenshots n/a

Version

Debug SCAN IMPORTANT Go to Developer tools in Home Assistant, choose Service tab and choose bosch.debug_scan Download file to your computer and upload it somewhere eg. https://jsonblob.com/

n/a

Additional context

n/a

pszafer commented 1 year ago

Fixed in https://github.com/bosch-thermostat/home-assistant-bosch-custom-component/releases/tag/v0.20.2

frenck commented 1 year ago

Nice! Thanks @pszafer! 👍

Happy New Year 🥂

../Frenck