boschmitt / tweedledum

C++17 Library for analysis, compilation/synthesis, and optimization of quantum circuits
MIT License
97 stars 36 forks source link

pip install fails #165

Open keithbriggs opened 2 years ago

keithbriggs commented 2 years ago

On a standard up-to-date Ubuntu 18 system:

python3.7 -m pip install tweedledum

    In file included from ../../../src/Parser/QASM/Lexer.h:8:0,
                     from ../../../src/Parser/QASM/Lexer.cpp:5:
    ../../../include/tweedledum/Utils/Source.h:8:10: fatal error: filesystem: No such file or directory
     #include <filesystem>
              ^~~~~~~~~~~~
    compilation terminated.
keithbriggs commented 2 years ago

I think the basic problem is that setup.py does not specify that g++ 8 or higher is needed.

boschmitt commented 2 years ago

I think the basic problem is that setup.py does not specify that g++ 8 or higher is needed.

Yes. It requires a compiler which supports C++17 (both core language and library features)

keithbriggs commented 2 years ago

So could a check for this be added to setup.py? Otherwise you get a failure with cryptic error messages.