Freeze pyrsistent version for python 2.7

boschresearch / pcg_gazebo

Procedural Generation for Gazebo

https://boschresearch.github.io/pcg_gazebo/

Apache License 2.0

69 stars 24 forks source link

Freeze pyrsistent version for python 2.7 #124

Closed awesomebytes closed 3 years ago

awesomebytes commented 3 years ago

Jupyter/nbformat pulls pyrsistent. The pyrsistent project is deprecating Python2.7 support, so freezing the version to 0.16.1 (the latest py2.7 supported version at the time of writing) workarounds it. Fixes #123

musamarcusso commented 3 years ago

hi @awesomebytes, thanks for your contribution, could you just sign-off your commit before I can merge, please :) ?

awesomebytes commented 3 years ago

Hello @musamarcusso I think it's done? Sorry, it's the first time I see that requirement. As the commits are already assigned to my Github user (and associated email) I would think it's enough. I force-pushed amending the commit message with what I found people do for sign-off commits.

choeppler commented 3 years ago

Hi @awesomebytes, I guess the contributing docs have been missing so it was rather impossible not to miss the that requirement... ;-) (@musamarcusso please correct me if I oversaw them.) See #126 on what the sign-off signifies.