TomF98
commented
1 year ago Hey, thanks for using TorchPhysics and your detailed problem description. Sampling in these kinds of domains is supported. Strangely, your code runs on my machine without any problems.
How did you install TorchPhysics? With pip install torchphysics or directly from GitHub? Another possible problem could be some mismatch in PyTorch versions.
With pip install torchphysics it should work. Which you can check, for example, on Google Colab by running the following (one has to install the library first, which takes around 2-3 minutes):
!pip install torchaudio==0.13.0
!pip install torchphysics
import torchphysics as tp
X = tp.spaces.R2("x")
R = tp.domains.Parallelogram(X, [0, 0], [3, 0], [0, 3])
A = tp.domains.Parallelogram(X, [1, 1], [2, 1], [2, 2])
O = R - A
sampler = tp.samplers.RandomUniformSampler(O, n_points=100)
pts = sampler.sample_points()
print(pts)And if you run this cell:
sampler = tp.samplers.RandomUniformSampler(O, n_points=2000)
fig = tp.utils.scatter(X, sampler)The sampling appears to work correctly.
mikeonly
Thanks for the nice library! I was writing a similar code to solve my inverse problem with PINNs when I stumbled upon your project, and decided to try using it, since it has nice sampling, domain creation, and conditions logic. However, I encounter a problem in a simple situation when I try to obtain points from a 2d domain which is a
CutDomain:This gives the assertion error in
__torch_function__:assert len(spaces) > 0, asserted here.Expected behavior:
Have 100 points from domain
O, which is a subtraction ofAfromR.Observed behavior:
sample_points()call runssample_domain_uniform()and inside_random_points_inside()when there should be a check of what points belong to the region, there is a eventually a linetorch.repeat_interleave(params, n, dim=0), which fails forparams = Points.empty()I would try to fix this issue myself, but I cannot understand the point of the function
_repeat_params, and of the assertion. Perhaps you can help clarifying the issue of what the code tries to check and why? Then I'd be able to write up a working version of the code for the case of 2d regions.Also, I stumbled somewhere that it might be not supported to sample from domains like that? Is that so?