search

boshiang / .NET-MVC-Workshop1

0 stars 0 forks source link

[CodeReview]-MVC-Controller #3

Open GSSBilly opened 5 years ago

GSSBilly commented 5 years ago

與規格不符，應以 Member 與 BookClass 與 BookCode 形式存取

https://github.com/boshiang/.NET-MVC-Workshop1/blob/79a504eadf447c8ba6b24d9401f5efdca4a57d39/Workshop2/Controllers/Book_maintenanceController.cs#L24-L52

GSSBilly commented 5 years ago

請簡化 namespace 使用

https://github.com/boshiang/.NET-MVC-Workshop1/blob/79a504eadf447c8ba6b24d9401f5efdca4a57d39/Workshop2/Controllers/Book_maintenanceController.cs#L64

GSSBilly commented 5 years ago

冗餘程式碼

https://github.com/boshiang/.NET-MVC-Workshop1/blob/79a504eadf447c8ba6b24d9401f5efdca4a57d39/Workshop2/Controllers/Book_maintenanceController.cs#L65

GSSBilly commented 5 years ago

分層負責

[資料應在 Model 層準備]

https://github.com/boshiang/.NET-MVC-Workshop1/blob/79a504eadf447c8ba6b24d9401f5efdca4a57d39/Workshop2/Controllers/Book_maintenanceController.cs#L66-L76

GSSBilly commented 5 years ago

例外處理，請勿保留原始堆疊，例外變數沒用到就不用宣告

https://github.com/boshiang/.NET-MVC-Workshop1/blob/79a504eadf447c8ba6b24d9401f5efdca4a57d39/Workshop2/Controllers/Book_maintenanceController.cs#L88-L91

GSSBilly commented 5 years ago

簡化 LINQ

[ 不須使用 Where 直接使用 FirstOrDefault]

https://github.com/boshiang/.NET-MVC-Workshop1/blob/79a504eadf447c8ba6b24d9401f5efdca4a57d39/Workshop2/Controllers/Book_maintenanceController.cs#L116