search

boskee / Minecraft

Simple Minecraft-inspired program using Python and Pyglet
MIT License
206 stars 33 forks source link

trees and cactuses #16

Closed ronmurphy closed 11 years ago

ronmurphy commented 11 years ago

I hope i am doing this right! just want to merge what I have with yours.

Implemented Jungle and Birch trees, added Cactus, made land generation to plants a bit more selective

BertrandBordage commented 11 years ago

These textures are fresh and beautiful! I prefer them to the original game. Did you make them specially for this clone?

EDIT: I got the answer when looking at blocks.py.

ronmurphy commented 11 years ago

Sorry for not responding earlier, went out to eat with the family. No, the artwork is from a Minecraft texturepack, Sphax Pure BDCraft. I am emailing the original author for permission to make use of tonight.

Sorry if I get so much code wrong, I am pretty much learning Python as I add on to this. Used to C# and VB.

On Thu, Apr 4, 2013 at 6:02 PM, Bertrand Bordage notifications@github.comwrote:

These textures are fresh and beautiful! I prefer them to the original game. Did you make them specially for this clone?

— Reply to this email directly or view it on GitHubhttps://github.com/boskee/Minecraft/pull/16#issuecomment-15926930 .

BertrandBordage commented 11 years ago

No problem, I'm happy to see this little game grow so fast :) I'll clean your code, don't worry.

ronmurphy commented 11 years ago

I just pushed a commit, added branches to Oak trees (jungle and birch have them rem'd out, but still there) and the cactus has the minecraft cactus ID also now.

Yeah, the progress is amazing! I go to bed, wake up, and just download the latest commit, hoping that something that i contributed made it in to that branch.

On Thu, Apr 4, 2013 at 8:10 PM, Bertrand Bordage notifications@github.comwrote:

No problem, I'm happy to see this little game grow so fast :) I'll clean your code, don't worry.

— Reply to this email directly or view it on GitHubhttps://github.com/boskee/Minecraft/pull/16#issuecomment-15932040 .

boskee commented 11 years ago

Can someone merge it with upstream? I don't feel like it right now (got to work in 6 hours).

BertrandBordage commented 11 years ago

Isn't that already merged?

ronmurphy commented 11 years ago

yeah i just grabbed boksee's latest right now... but as how i am on windows, i dont know how to get AVBin to work.it did not come in the source download of pyglet alpha. I guess i need to find a pre-compiled egg?

On 4/4/13, Bertrand Bordage notifications@github.com wrote:

Isn't that already merged?

Reply to this email directly or view it on GitHub: https://github.com/boskee/Minecraft/pull/16#issuecomment-15933860

BertrandBordage commented 11 years ago

I'm currently rewriting what was already merged.

ronmurphy commented 11 years ago

well that is a heck of a job! I am having python issues on windows, so i am installing Fedora in a virtual box, and i will continue ot code that way

On 4/4/13, Bertrand Bordage notifications@github.com wrote:

I'm currently rewriting what was already merged.

Reply to this email directly or view it on GitHub: https://github.com/boskee/Minecraft/pull/16#issuecomment-15935004

embatbr commented 11 years ago

In the actual state of production, is necessary to clean the garbage (the game code and resources in the root dir)

ronmurphy commented 11 years ago

in my last commit changed the blocks.py to include "branches" to the trees, that also add in more leaves, but only for the Oak trees, as how to make each tree different. i also have in effect that in the desert terrain, and i think for all terrains now, under sand, two blocks down, is sandstone.

I dont know if this is worth keeping, your call.

Tomorrow I plan on adding in melons and pumpkins, do you have any suggestions for other blocks?

On Thu, Apr 4, 2013 at 10:10 PM, Eduardo Tenório notifications@github.comwrote:

In the actual state of production, is necessary to clean the garbage (the game code and resources in the root dir)

— Reply to this email directly or view it on GitHubhttps://github.com/boskee/Minecraft/pull/16#issuecomment-15935698 .

BertrandBordage commented 11 years ago

Partial rewriting of this pull request in #22. Have fun with the pumpkins, this shouldn't be hard! :)

ronmurphy commented 11 years ago

I am having a big issue, sound wont work for me (Windows...) so i rem'd the items with it, and now i get this error... any idea what it is?

C:\Python>python c:\Python\Minecraft-master\main.py --s Traceback (most recent call last): File "c:\Python\Minecraft-master\main.py", line 1408, main(options) File "c:\Python\Minecraft-master\main.py", line 1372, resizable=True, save=save_object) #, vsync=False) File "c:\Python\Minecraft-master\main.py", line 832, self.key_move_forward = config.getint('Controls', ' File "C:\Python\lib\ConfigParser.py", line 359, in ge return self._get(section, int, option) File "C:\Python\lib\ConfigParser.py", line 356, in _g return conv(self.get(section, option)) File "C:\Python\lib\ConfigParser.py", line 607, in ge raise NoSectionError(section) ConfigParser.NoSectionError: No section: 'Controls'

On 4/4/13, Bertrand Bordage notifications@github.com wrote:

Partial rewriting of this pull request in #22. Have fun with the pumpkins, this shouldn't be hard! :)

Reply to this email directly or view it on GitHub: https://github.com/boskee/Minecraft/pull/16#issuecomment-15937012

BertrandBordage commented 11 years ago

This is due to 0b5bc03f6de8c2c3a92a46422eb519c7a8722cbb. You have to remove your "game.cfg", but the directory isn't the game directory anymore. This should be in something like C:\Users\You\Application Data\.pyCraftr\ on Windows.

ronmurphy commented 11 years ago

thanks. we may need to do a --clear-config to remove the old config and init a new one. I cant get to the Application Data folder (windows is protecting it i think) so i will just wait until tomorrow. until then, graphics editing and splicing i think :D

Thanks for the help! I really do appreciate it!

On Thu, Apr 4, 2013 at 11:21 PM, Bertrand Bordage notifications@github.comwrote:

This is due to 0b5bc03https://github.com/boskee/Minecraft/commit/0b5bc03f6de8c2c3a92a46422eb519c7a8722cbb. You have to remove your "game.cfg", but the directory isn't the game directory anymore. This should be in something like C:\Users\You\Application Data.pyCraftr\ on Windows.

— Reply to this email directly or view it on GitHubhttps://github.com/boskee/Minecraft/pull/16#issuecomment-15937238 .

BertrandBordage commented 11 years ago

Oh, I just looked at your facebook. Sorry if I seemed a bit harsh, that wasn't done on purpose.

Anyway, it's true that a --clear-config or --reset-config could be great.

ronmurphy commented 11 years ago

no it is ok, i have been wanting to learn python for years now :D

i have tried this, but it does not work... <bad formatting ahead!>

in def main:

if options.newcfg == True:

if (os.path.exists(config_file)):

os.remove(config_file)

with this in main

parser.add_argument("-newcfg", action="store_true",default=False)

os.delete did not work, os.remove seemed to work, but now it cant find texture.png. os.unlink did nothing... I will try tomorrow i think.

On Thu, Apr 4, 2013 at 11:39 PM, Bertrand Bordage notifications@github.comwrote:

Oh, I just looked at your facebook. Sorry if I seemed a bit harsh, that wasn't done on purpose.

Anyway, it's true that a --clear-config or --reset-config could be great.

— Reply to this email directly or view it on GitHubhttps://github.com/boskee/Minecraft/pull/16#issuecomment-15937597 .

BertrandBordage commented 11 years ago

As I wiped out my Windows when Steam came to Ubuntu, I can't help you, I fear… And it's time to go to bed for me…

ronmurphy commented 11 years ago

Same here.. night :D

On Thu, Apr 4, 2013 at 11:58 PM, Bertrand Bordage notifications@github.comwrote:

As I wiped out my Windows when Steam came to Ubuntu, I can't help you, I fear… And it's time to go to bed for me…

— Reply to this email directly or view it on GitHubhttps://github.com/boskee/Minecraft/pull/16#issuecomment-15937917 .