bosmoment / PineTime-apps

Firmware for the PineTime based on RIOT, NimBLE and LittleVGL
GNU Lesser General Public License v2.1
79 stars 32 forks source link

include device name in BT advertisments #9

Open danielkucera opened 4 years ago

bergzand commented 4 years ago

You're right that the name should be included in the advertisements. If I shorten the name to something like "RIOT", my Gadgetbridge picks up the device just fine. The weird thing is that Linux seems to pick up the default name fine while Gadgetbridge does not detect the name.

The issue here is that the default device name in combination with the 128 bit UUID exceeds the max length of an advertisement. I'm afraid that with your current fix, the 128 bit UUID is no longer included in the advertisement, is this correct?

I'll check if extended advertisements can be used here to solve this issue.

danielkucera commented 4 years ago

The issue here is that the default device name in combination with the 128 bit UUID exceeds the max length of an advertisement. I'm afraid that with your current fix, the 128 bit UUID is no longer included in the advertisement, is this correct?

I don't remember by hard but I think I have not seen the UUID in the advertisement. And even with this patch, my watch was detected by gadgetbridge instantly.