search

bosnet / sebak

SEBAK, the next BOScoin Blockchain
https://devteam.blockchainos.org
GNU General Public License v3.0
44 stars 15 forks source link

Change IsValidVotingBasis to return the reason of the mismatch #839

Closed Geod24 closed 5 years ago

Geod24 commented 5 years ago 
Make it more obvious what went wrong, also add documentation
codecov-io commented 5 years ago

Codecov Report

Merging #839 into master will increase coverage by 0.07%. The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
+ Coverage   61.97%   62.04%   +0.07%     
==========================================
  Files         151      151              
  Lines        9913     9913              
==========================================
+ Hits         6144     6151       +7     
+ Misses       3109     3098      -11     
- Partials      660      664       +4
Flag Coverage Δ
#integration_tests_long_term 45.59% <76.47%> (-0.09%) :arrow_down:
#integration_tests_node 41.16% <76.47%> (+0.14%) :arrow_up:
#unittests 51.3% <5.88%> (ø) :arrow_up:
Impacted Files Coverage Δ
lib/node/runner/checker.go 73.33% <100%> (ø) :arrow_up:
lib/consensus/isaac.go 85.9% <83.33%> (ø) :arrow_up:
lib/common/http2_client.go 46.26% <0%> (-2.99%) :arrow_down:
lib/network/http2_client.go 51.21% <0%> (-2.44%) :arrow_down:
lib/network/http2.go 88.18% <0%> (-1.58%) :arrow_down:
lib/node/runner/node_runner.go 78.31% <0%> (-0.46%) :arrow_down:
lib/node/runner/api/api.go 66.17% <0%> (+22.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11b19a7...e126e1b. Read the comment docs.

Geod24 commented 5 years ago

Rebase + updated according to @Charleslee522 / @spikeekips ' comments

anarcher commented 5 years ago

Sometimes, l feel that Reason struct is necessary for various reason.. Haha