search

bosnet / sebak

SEBAK, the next BOScoin Blockchain
https://devteam.blockchainos.org
GNU General Public License v3.0
44 stars 15 forks source link

tx resource contains operations #863

Closed kfangw closed 5 years ago

kfangw commented 5 years ago

Github Issue

862

Background

see #862

Solution

Transaction Resource contains operations

Possible Drawbacks

codecov-io commented 5 years ago

Codecov Report

Merging #863 into master will increase coverage by 1.95%. The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage   58.21%   60.16%   +1.95%     
==========================================
  Files         154      154              
  Lines       10996    11003       +7     
==========================================
+ Hits         6401     6620     +219     
+ Misses       3847     3607     -240     
- Partials      748      776      +28
Flag Coverage Δ
#integration_tests_long_term 44.05% <0%> (?)
#integration_tests_node 40.02% <0%> (-0.03%) :arrow_down:
#unittests 48.44% <52.94%> (-0.07%) :arrow_down:
Impacted Files Coverage Δ
lib/node/runner/api/api.go 85% <ø> (+24.28%) :arrow_up:
lib/node/runner/api/stream.go 42.62% <0%> (-6.91%) :arrow_down:
lib/node/runner/api/resource/transaction.go 59.45% <100%> (+2.31%) :arrow_up:
lib/node/runner/api/resource/operation.go 83.33% <100%> (+0.57%) :arrow_up:
lib/node/runner/api/transaction.go 58.71% <69.56%> (-7.33%) :arrow_down:
cmd/sebak/cmd/run.go 57.44% <0%> (+0.35%) :arrow_up:
lib/node/runner/isaac_state_manager.go 94.31% <0%> (+1.42%) :arrow_up:
lib/node/runner/api_block.go 67.5% <0%> (+1.66%) :arrow_up:
lib/block/transaction.go 70.12% <0%> (+1.82%) :arrow_up:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 359ae36...824fd71. Read the comment docs.

kfangw commented 5 years ago

review please @spikeekips @anarcher @Geod24

kfangw commented 5 years ago

Ping @anarcher @spikeekips @Geod24

kfangw commented 5 years ago

@cmcm2222 When this merged, please update the API document according to this change.

kfangw commented 5 years ago

ping @anarcher @Geod24

kfangw commented 5 years ago

@cmcm2222 Could you test this PR and update the Document? I want to merge this when you are ready for the document.

kfangw commented 5 years ago

@cmcm2222 Could you test this PR and update the Document? I want to merge this when you are ready for the document.

@cmcm2222 ping

johndoe0x commented 5 years ago

@kfangw OK. I will check it