bosnet / sebak

SEBAK, the next BOScoin Blockchain
https://devteam.blockchainos.org
GNU General Public License v3.0
44 stars 15 forks source link

Rename GetBlockOperationsByTxHash to GetBlockOperationsByTx #864

Closed Geod24 closed 5 years ago

Geod24 commented 5 years ago

Because hash is implied when getting an association.

codecov-io commented 5 years ago

Codecov Report

Merging #864 into master will increase coverage by 0.1%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #864     +/-   ##
=========================================
+ Coverage   60.44%   60.55%   +0.1%     
=========================================
  Files         152      152             
  Lines       10353    10353             
=========================================
+ Hits         6258     6269     +11     
+ Misses       3388     3378     -10     
+ Partials      707      706      -1
Flag Coverage Δ
#integration_tests_long_term 44.11% <12.5%> (+0.1%) :arrow_up:
#integration_tests_node 39.76% <12.5%> (ø) :arrow_up:
#unittests 50.15% <87.5%> (ø) :arrow_up:
Impacted Files Coverage Δ
lib/block/operation.go 58.67% <0%> (ø) :arrow_up:
lib/node/runner/api/tx_operations.go 69.56% <100%> (ø) :arrow_up:
lib/node/runner/node_runner.go 77.46% <100%> (ø) :arrow_up:
lib/network/validator_connection_manager.go 88.23% <0%> (+6.61%) :arrow_up:
lib/common/message.go 42.1% <0%> (+10.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cc0ebd...ed6bf72. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #864 into master will increase coverage by 0.12%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
+ Coverage   60.42%   60.55%   +0.12%     
==========================================
  Files         152      152              
  Lines       10353    10353              
==========================================
+ Hits         6256     6269      +13     
+ Misses       3389     3378      -11     
+ Partials      708      706       -2
Flag Coverage Δ
#integration_tests_long_term 44.19% <12.5%> (+0.18%) :arrow_up:
#integration_tests_node 39.76% <12.5%> (ø) :arrow_up:
#unittests 50.13% <87.5%> (ø) :arrow_up:
Impacted Files Coverage Δ
lib/block/operation.go 58.67% <0%> (ø) :arrow_up:
lib/node/runner/api/tx_operations.go 69.56% <100%> (ø) :arrow_up:
lib/node/runner/node_runner.go 77.02% <100%> (ø) :arrow_up:
lib/node/runner/checker.go 73.77% <0%> (+0.44%) :arrow_up:
lib/network/validator_connection_manager.go 88.23% <0%> (+6.61%) :arrow_up:
lib/common/message.go 42.1% <0%> (+10.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 287b070...f3a7668. Read the comment docs.

soonkuk commented 5 years ago

LGTM!