bosnet / sebak

SEBAK, the next BOScoin Blockchain
https://devteam.blockchainos.org
GNU General Public License v3.0
44 stars 15 forks source link

Refactor/document hash-related functions #898

Closed Geod24 closed 5 years ago

Geod24 commented 5 years ago

A rather minor PRs with a few commits that have been longing on other PRs for a while that I'd like to get in instead of constantly rebasing them :)

codecov-io commented 5 years ago

Codecov Report

Merging #898 into master will decrease coverage by 0.05%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   60.42%   60.36%   -0.06%     
==========================================
  Files         153      153              
  Lines       10774    10768       -6     
==========================================
- Hits         6510     6500      -10     
- Misses       3521     3523       +2     
- Partials      743      745       +2
Flag Coverage Δ
#integration_tests_long_term 44.49% <75%> (-0.06%) :arrow_down:
#integration_tests_node 40.37% <75%> (-0.08%) :arrow_down:
#unittests 48.6% <75%> (-0.02%) :arrow_down:
Impacted Files Coverage Δ
lib/transaction/operation/operation.go 38.53% <ø> (-2.18%) :arrow_down:
lib/block/operation.go 58.67% <100%> (ø) :arrow_up:
lib/node/runner/block_operations.go 65.43% <100%> (ø) :arrow_up:
lib/block/transaction.go 70.12% <100%> (ø) :arrow_up:
lib/common/hash.go 77.77% <60%> (+7.77%) :arrow_up:
lib/sync/fetcher.go 57.5% <0%> (-7.5%) :arrow_down:
lib/sync/try.go 78.57% <0%> (-7.15%) :arrow_down:
lib/metrics/sync.go 88.57% <0%> (-5.72%) :arrow_down:
lib/network/validator_connection_manager.go 87.74% <0%> (+2.76%) :arrow_up:
lib/common/message.go 42.1% <0%> (+10.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1ae687...52db224. Read the comment docs.