search

bosnet / sebak

SEBAK, the next BOScoin Blockchain
https://devteam.blockchainos.org
GNU General Public License v3.0
44 stars 15 forks source link

Minor refactoring the the CLI code #911

Closed Geod24 closed 5 years ago

Geod24 commented 5 years ago

Those 2 commits were part of https://github.com/bosnet/sebak/pull/904 but this PR is blocked on JSONRPC deployment. However, those 2 can be pulled independently.

codecov-io commented 5 years ago

Codecov Report

Merging #911 into master will increase coverage by 0.01%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   60.19%   60.21%   +0.01%     
==========================================
  Files         156      156              
  Lines       11100    11095       -5     
==========================================
- Hits         6682     6681       -1     
+ Misses       3629     3624       -5     
- Partials      789      790       +1
Flag Coverage Δ
#integration_tests_long_term 44.01% <33.33%> (+0.02%) :arrow_up:
#integration_tests_node 40.64% <33.33%> (+0.02%) :arrow_up:
#unittests 48.16% <100%> (+0.03%) :arrow_up:
Impacted Files Coverage Δ
cmd/sebak/cmd/genesis.go 31.19% <ø> (+2.13%) :arrow_up:
cmd/sebak/cmd/run.go 56.92% <100%> (+0.31%) :arrow_up:
cmd/sebak/common/util.go 30% <25%> (-1.25%) :arrow_down:
lib/node/runner/node_runner.go 77.41% <0%> (-0.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60bb087...01316ae. Read the comment docs.