search

bosnet / sebak

SEBAK, the next BOScoin Blockchain
https://devteam.blockchainos.org
GNU General Public License v3.0
44 stars 15 forks source link

Updating go modules #913

Closed spikeekips closed 5 years ago

spikeekips commented 5 years ago

Background

The go modules of SEBAK is updated to the latest version.

Anyway, some weird phenomenon found; $ go get -u github.com/GianlucaGuarini/go-observable set the old version,

-       github.com/GianlucaGuarini/go-observable v0.0.0-20180829201609-d386f0081a66
+       github.com/GianlucaGuarini/go-observable v0.0.0-20171228155646-e39e699e0a00
codecov-io commented 5 years ago

Codecov Report

Merging #913 into master will increase coverage by 1.86%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
+ Coverage    58.6%   60.47%   +1.86%     
==========================================
  Files         159      159              
  Lines       11203    11203              
==========================================
+ Hits         6566     6775     +209     
+ Misses       3870     3629     -241     
- Partials      767      799      +32
Flag Coverage Δ
#integration_tests_long_term 44.13% <ø> (?)
#integration_tests_node 40.57% <ø> (ø) :arrow_up:
#integration_tests_retry 37.16% <ø> (-0.06%) :arrow_down:
#unittests 47.68% <ø> (ø) :arrow_up:
Impacted Files Coverage Δ
lib/block/transaction.go 70.12% <0%> (+1.82%) :arrow_up:
lib/node/runner/api_block.go 61.17% <0%> (+2.35%) :arrow_up:
lib/network/validator_connection_manager.go 77.63% <0%> (+2.79%) :arrow_up:
lib/metrics/consensus.go 100% <0%> (+2.89%) :arrow_up:
lib/client/client.go 3.46% <0%> (+3.46%) :arrow_up:
lib/common/time.go 38.18% <0%> (+3.63%) :arrow_up:
lib/consensus/isaac.go 84.93% <0%> (+4.21%) :arrow_up:
lib/sync/try.go 85.71% <0%> (+7.14%) :arrow_up:
lib/transaction/pool.go 75.75% <0%> (+8.08%) :arrow_up:
lib/sync/fetcher.go 65% <0%> (+11.25%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2fc403...9177204. Read the comment docs.

Geod24 commented 5 years ago

Anyway, some weird phenomenon found; $ go get -u github.com/GianlucaGuarini/go-observable set the old version,

That's because we are using the dev branch and go get will fetch master. And dev contains my fixes to avoid race conditions.

Geod24 commented 5 years ago

Why was this merged ? The changes to go-observable are still there...

spikeekips commented 5 years ago

@Geod24 I did not know you are doing something. As you mentioned, observable package still remains the old one.