Closed Geod24 closed 5 years ago
Merging #922 into master will decrease coverage by
0.01%
. The diff coverage is58.33%
.
@@ Coverage Diff @@
## master #922 +/- ##
==========================================
- Coverage 60.75% 60.73% -0.02%
==========================================
Files 159 160 +1
Lines 11260 11267 +7
==========================================
+ Hits 6841 6843 +2
- Misses 3615 3617 +2
- Partials 804 807 +3
Flag | Coverage Δ | |
---|---|---|
#integration_tests_long_term | 44.05% <25%> (+0.18%) |
:arrow_up: |
#integration_tests_node | 40.52% <25%> (-0.04%) |
:arrow_down: |
#integration_tests_retry | 37.69% <25%> (-0.04%) |
:arrow_down: |
#unittests | 47.36% <58.33%> (-0.07%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
lib/network/test.go | 100% <100%> (ø) |
:arrow_up: |
lib/node/local_node.go | 79% <50%> (-2.64%) |
:arrow_down: |
lib/node/test.go | 60% <60%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6a0f6ca...0f57854. Read the comment docs.
Merging #922 into master will decrease coverage by
0.01%
. The diff coverage is58.33%
.
@@ Coverage Diff @@
## master #922 +/- ##
==========================================
- Coverage 60.75% 60.73% -0.02%
==========================================
Files 159 160 +1
Lines 11260 11267 +7
==========================================
+ Hits 6841 6843 +2
- Misses 3615 3617 +2
- Partials 804 807 +3
Flag | Coverage Δ | |
---|---|---|
#integration_tests_long_term | 44.05% <25%> (+0.18%) |
:arrow_up: |
#integration_tests_node | 40.52% <25%> (-0.04%) |
:arrow_down: |
#integration_tests_retry | 37.69% <25%> (-0.04%) |
:arrow_down: |
#unittests | 47.36% <58.33%> (-0.07%) |
:arrow_down: |
Impacted Files | Coverage Δ | |
---|---|---|
lib/network/test.go | 100% <100%> (ø) |
:arrow_up: |
lib/node/local_node.go | 79% <50%> (-2.64%) |
:arrow_down: |
lib/node/test.go | 60% <60%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6a0f6ca...0f57854. Read the comment docs.
Once again, getting rid of missing
error
checks and simplifying test code by providing trivial wrapper... Which would not be necessary if go had default parameter, but that's another story.