bosnet / sebak

SEBAK, the next BOScoin Blockchain
https://devteam.blockchainos.org
GNU General Public License v3.0
44 stars 15 forks source link

Simplify publishURL parsing in cmd #924

Closed Geod24 closed 5 years ago

Geod24 commented 5 years ago

Pretty simple, instead of having two separated code path, we only branch out if there is no value.

codecov-io commented 5 years ago

Codecov Report

Merging #924 into master will decrease coverage by 0.01%. The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
- Coverage   60.75%   60.74%   -0.02%     
==========================================
  Files         160      160              
  Lines       11250    11247       -3     
==========================================
- Hits         6835     6832       -3     
  Misses       3609     3609              
  Partials      806      806
Flag Coverage Δ
#integration_tests_long_term 44.05% <71.42%> (+0.01%) :arrow_up:
#integration_tests_node 40.55% <71.42%> (+0.01%) :arrow_up:
#integration_tests_retry 37.73% <71.42%> (+0.02%) :arrow_up:
#unittests 47.38% <71.42%> (+0.01%) :arrow_up:
Impacted Files Coverage Δ
cmd/sebak/cmd/run.go 56.7% <71.42%> (-0.23%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5329bd...caa72c0. Read the comment docs.

Geod24 commented 5 years ago

Ping @Charleslee522 @spikeekips